Fixed a problem that IconButton/IconToggle cannot be disabled #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hallelujahdrive, thank you very much for this contribution. I will take a look at it as soon as I find the time! |
|
Hi @hallelujahdrive, I merged this as 66d0967. Thank you for this contribution and thank you for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IconButton/IconToggle'ssetDisabledwasn't really working, so I tried implementing it.After considering several approaches, I chose the implementation that does not instantiate
MDCIconButtonTogglefrommdc-icon-buttonand uses the button element placed as a child node.Since I have set the style of mdc-icon-button to
display:contents;, the wrapper has no visual effect and does not affect the layout.This change may cause a problem that style is not applied as expected when setting style for
IconButton/IconToggleusing child combinator or sibling combinator in CSS. Someone may need to modify CSS.The most ideal approach to the problem is to extend
HTMLButtonElement, but even the latest elm didn't support custom elements that extend the built-in element. (elm/virtual-dom#156)I think there are other implementations besides my code, but some compromise will be required anyway.