-
-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unicode version16 jdk24 #6025
Unicode version16 jdk24 #6025
Conversation
As per the openJDK release notes for JDK 24 (See : https://jdk.java.net/24/release-notes) CLDR was updated to version 46 and Unicode version was updated to ver. 16.0.0. This commit has been done to: 1. Update the test case with unicode files of version 16. ( See README at unicode/data/README.txt). 2. Update the JDK version to 24 and map its Unicode version to 16.0.0. (See UnicodeVers.properties at unicode/resources/UnicodeVers.properties).
Unicode version in JDK24 has been changed to 16.0.0. We are updating the relevant files in data folder in unicode test case.
hi @rishabh-ibm - please make sure you sign the ECA (details here: https://adoptium.net/docs/eca-sign-off/) You can also add a fixes or closes keyword in the description as this PR will address #6023 (info: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) |
Thanks @rishabh-ibm :) |
@llxia can we run this test case from my branch once? |
@rishabh-ibm Please move the PR out of draft. Thanks. |
Good work @rishabh-ibm ! hi @llxia - I can't see the hyc links, so can not tell if you also checked AIX and windows platforms, which also have test targets that fail without this update (listed in #6023). Windows: https://ci.adoptium.net/job/Grinder/12771 - MBCS_Tests_codepoint_windows fails |
My understanding is this PR is for MBCS_Tests_unicode (not codepoint). Codepoint needs seaparte PR (see #6025 (comment)) Grinder with For |
@llxia Its out of draft mode now. Requires 2 reviews, but I am unable to assign it to you. This leaves locale matching. JDK24 release notes talk of few changes to locales as well. That might just require adjustments for the locale changes. Probably an adjustment to the locale codes for one of our tests input. I am looking for more information on it. Once we have more information, we can try and resolve it as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rishabh-ibm
* Update MBCSTests for JDK24+ As per the openJDK release notes for JDK 24 (See : https://jdk.java.net/24/release-notes) CLDR was updated to version 46 and Unicode version was updated to ver. 16.0.0. This commit has been done to: 1. Update the test case with unicode files of version 16. ( See README at unicode/data/README.txt). 2. Update the JDK version to 24 and map its Unicode version to 16.0.0. (See UnicodeVers.properties at unicode/resources/UnicodeVers.properties). * Enabling Unicode test case for JDK24+ * logs Commit in unicodeVers * Adding Unicode 16.0.0 files to data folder Unicode version in JDK24 has been changed to 16.0.0. We are updating the relevant files in data folder in unicode test case.
* Update MBCSTests for JDK24+ As per the openJDK release notes for JDK 24 (See : https://jdk.java.net/24/release-notes) CLDR was updated to version 46 and Unicode version was updated to ver. 16.0.0. This commit has been done to: 1. Update the test case with unicode files of version 16. ( See README at unicode/data/README.txt). 2. Update the JDK version to 24 and map its Unicode version to 16.0.0. (See UnicodeVers.properties at unicode/resources/UnicodeVers.properties). * Enabling Unicode test case for JDK24+ * logs Commit in unicodeVers * Adding Unicode 16.0.0 files to data folder Unicode version in JDK24 has been changed to 16.0.0. We are updating the relevant files in data folder in unicode test case. Co-authored-by: Rishabh Thakur <[email protected]>
As per the openJDK release notes for JDK 24 (See : https://jdk.java.net/24/release-notes) CLDR was updated to version 46
and Unicode version was updated to ver. 16.0.0.
This commit has been done to:
Update the test case with unicode files of version 16. ( See README at unicode/data/README.txt).
Update the JDK version to 24 and map its Unicode version to 16.0.0. (See UnicodeVers.properties at unicode/resources/UnicodeVers.properties).