Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode version16 jdk24 #6025

Merged
merged 5 commits into from
Mar 14, 2025
Merged

Conversation

rishabh-ibm
Copy link
Contributor

As per the openJDK release notes for JDK 24 (See : https://jdk.java.net/24/release-notes) CLDR was updated to version 46
and Unicode version was updated to ver. 16.0.0.

This commit has been done to:

  1. Update the test case with unicode files of version 16. ( See README at unicode/data/README.txt).

  2. Update the JDK version to 24 and map its Unicode version to 16.0.0. (See UnicodeVers.properties at unicode/resources/UnicodeVers.properties).

As per the openJDK release notes for JDK 24 (See : https://jdk.java.net/24/release-notes) CLDR was updated to version 46 and Unicode version was updated to ver. 16.0.0.

This commit has been done to:
1. Update the test case with unicode files of version 16. ( See README at unicode/data/README.txt).
2. Update the JDK version to 24 and map its Unicode version to 16.0.0. (See UnicodeVers.properties at unicode/resources/UnicodeVers.properties).
Unicode version in JDK24 has been changed to 16.0.0. We are updating the relevant files in data folder in unicode test case.
@smlambert
Copy link
Contributor

hi @rishabh-ibm - please make sure you sign the ECA (details here: https://adoptium.net/docs/eca-sign-off/)

You can also add a fixes or closes keyword in the description as this PR will address #6023 (info: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests)

@llxia
Copy link
Contributor

llxia commented Mar 13, 2025

Thanks @rishabh-ibm :)

@rishabh-ibm
Copy link
Contributor Author

@llxia can we run this test case from my branch once?
I have tried running, but looks like one of the options chosen by me might be off.
If we resolve this, we will need a very similar change for codepoint as well.
Same files(2 of them) and entries in the property files.

@llxia
Copy link
Contributor

llxia commented Mar 13, 2025

JDK24 alinux MBCS_Tests_unicode_linux_0 - passed
JDK11 alinux MBCS_Tests_unicode_linux_0 - passed
JDK24 alinux special.functional - passed

@llxia
Copy link
Contributor

llxia commented Mar 13, 2025

@rishabh-ibm Please move the PR out of draft. Thanks.

@smlambert
Copy link
Contributor

smlambert commented Mar 13, 2025

Good work @rishabh-ibm !

hi @llxia - I can't see the hyc links, so can not tell if you also checked AIX and windows platforms, which also have test targets that fail without this update (listed in #6023).

Windows: https://ci.adoptium.net/job/Grinder/12771 - MBCS_Tests_codepoint_windows fails
AIX: https://ci.adoptium.net/job/Grinder/12773 - MBCS_Tests_codepoint_aix and 3 variants of MBCS_Tests_locale_matching_zh_CN_aix (zh, Zh, ZH) fail

@llxia
Copy link
Contributor

llxia commented Mar 14, 2025

My understanding is this PR is for MBCS_Tests_unicode (not codepoint). Codepoint needs seaparte PR (see #6025 (comment))

Grinder with MBCS_Tests_unicode_windows passed: https://ci.adoptium.net/job/Grinder/12775/

For MBCS_Tests_unicode issue, see eclipse-openj9/openj9#21187

@rishabh-ibm rishabh-ibm marked this pull request as ready for review March 14, 2025 00:40
@rishabh-ibm
Copy link
Contributor Author

@llxia Its out of draft mode now. Requires 2 reviews, but I am unable to assign it to you.
I will push codepoint changes as well in few minutes.

This leaves locale matching. JDK24 release notes talk of few changes to locales as well. That might just require adjustments for the locale changes. Probably an adjustment to the locale codes for one of our tests input. I am looking for more information on it. Once we have more information, we can try and resolve it as well.

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rishabh-ibm

@llxia llxia requested a review from smlambert March 14, 2025 01:14
@smlambert smlambert merged commit ffe4654 into adoptium:master Mar 14, 2025
2 of 3 checks passed
annaibm pushed a commit to annaibm/aqa-tests that referenced this pull request Mar 18, 2025
* Update MBCSTests for JDK24+

As per the openJDK release notes for JDK 24 (See : https://jdk.java.net/24/release-notes) CLDR was updated to version 46 and Unicode version was updated to ver. 16.0.0.

This commit has been done to:
1. Update the test case with unicode files of version 16. ( See README at unicode/data/README.txt).
2. Update the JDK version to 24 and map its Unicode version to 16.0.0. (See UnicodeVers.properties at unicode/resources/UnicodeVers.properties).

* Enabling Unicode test case for JDK24+

* logs Commit in unicodeVers

* Adding Unicode 16.0.0 files to data folder

Unicode version in JDK24 has been changed to 16.0.0. We are updating the relevant files in data folder in unicode test case.
llxia pushed a commit that referenced this pull request Mar 18, 2025
* Update MBCSTests for JDK24+

As per the openJDK release notes for JDK 24 (See : https://jdk.java.net/24/release-notes) CLDR was updated to version 46 and Unicode version was updated to ver. 16.0.0.

This commit has been done to:
1. Update the test case with unicode files of version 16. ( See README at unicode/data/README.txt).
2. Update the JDK version to 24 and map its Unicode version to 16.0.0. (See UnicodeVers.properties at unicode/resources/UnicodeVers.properties).

* Enabling Unicode test case for JDK24+

* logs Commit in unicodeVers

* Adding Unicode 16.0.0 files to data folder

Unicode version in JDK24 has been changed to 16.0.0. We are updating the relevant files in data folder in unicode test case.

Co-authored-by: Rishabh Thakur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants