-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove com.test.jlink to eliminate xlC dependency #498
Conversation
- Remove com.test.jlink to eliminate xlC dependency in system tests related:adoptium/aqa-tests#5965 Signed-off-by: Anna Babu Palathingal <[email protected]>
f2c4b3b
to
edf49c3
Compare
Grinder runs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
openjdk.test.modularity/build.xml
Outdated
|
||
<target name="build-natives" depends="check-prereqs, check-compiler-level, setup-native-build-command, build-natives-windows, build-natives-unix"> | ||
|
||
<target name="build-natives" depends="check-prereqs, check-compiler-level, setup-native-build-command"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need this target?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this target is not needed, but I will verify by removing it and running the build to confirm there are no issues. I’ll update once testing is complete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and pls check if setup-native-build-command is also still needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed the targets -build-natives
and setup-native-build-command
, and Grinder passed without issues.
sanity.system tests: Grinder #48601
extended.system tests: Grinder #48600
Let me know if any further changes are needed.
related:adoptium/aqa-tests#5965