Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove com.test.jlink to eliminate xlC dependency #498

Merged
merged 3 commits into from
Mar 5, 2025

Conversation

annaibm
Copy link
Contributor

@annaibm annaibm commented Feb 21, 2025

  • Remove com.test.jlink to eliminate xlC dependency in system tests

related:adoptium/aqa-tests#5965

- Remove com.test.jlink to eliminate xlC dependency in system tests

related:adoptium/aqa-tests#5965
Signed-off-by: Anna Babu Palathingal <[email protected]>
@annaibm
Copy link
Contributor Author

annaibm commented Mar 5, 2025

@annaibm annaibm marked this pull request as ready for review March 5, 2025 16:29
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia requested a review from pshipton March 5, 2025 19:34

<target name="build-natives" depends="check-prereqs, check-compiler-level, setup-native-build-command, build-natives-windows, build-natives-unix">

<target name="build-natives" depends="check-prereqs, check-compiler-level, setup-native-build-command">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this target?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this target is not needed, but I will verify by removing it and running the build to confirm there are no issues. I’ll update once testing is complete.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and pls check if setup-native-build-command is also still needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the targets -build-natives and setup-native-build-command, and Grinder passed without issues.
sanity.system tests: Grinder #48601
extended.system tests: Grinder #48600
Let me know if any further changes are needed.

@karianna karianna requested a review from pshipton March 5, 2025 22:09
@pshipton pshipton merged commit 2c3cbfc into adoptium:master Mar 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants