Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(button,link): add more static color tests #3374

Merged
merged 1 commit into from
Nov 12, 2024
Merged

chore(button,link): add more static color tests #3374

merged 1 commit into from
Nov 12, 2024

Conversation

castastrophe
Copy link
Collaborator

@castastrophe castastrophe commented Nov 6, 2024 •
edited
Loading

Description

Expand test coverage for variants in static color modes.

  • ActionButton: new static black & white tests covering default, emphasized, quiet
  • Button: Updated format of testing to show fill & outline variants side-by-side with color variations together and then iterated over by state; new static white & static black tests iterate over more variants and states; truncation & line-wraps expanded
  • ClearButton: Add quiet testing
  • Link: Add static secondary testing

Other diffs relate to the update to the border color.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

To-do list

@castastrophe castastrophe added testing Visual regression testing run_vrt For use on PRs looking to kick off VRT labels Nov 6, 2024
@castastrophe castastrophe self-assigned this Nov 6, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9982c4e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024 •
edited
Loading

🚀 Deployed on https://pr-3374--spectrum-css.netlify.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024 •
edited
Loading

File metrics

Summary

Total size: 4.26 MB*

🎉 No changes detected in any packages

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@castastrophe castastrophe force-pushed the chore-static-color-tests branch 3 times, most recently from f4ebabb to ce0400b Compare November 11, 2024 17:33
@castastrophe
Copy link
Collaborator Author

VRT changes: https://www.chromatic.com/build?appId=64762974a45b8bc5ca1705a2&number=3736

@castastrophe castastrophe added skip_vrt Add to a PR to skip running VRT (but still pass the action) and removed run_vrt For use on PRs looking to kick off VRT labels Nov 12, 2024
cdransf
cdransf approved these changes Nov 12, 2024
View reviewed changes
components/button/stories/button.test.js
testHeading: "UI icon",
content: Template({
...args,
// Uses a UI icon that is smaller than workflow sizing, to test alignment:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most minor of nits but I'd be inclined to remove : as we can assume the comment pertains to the line(s) that follow. ✨

components/button/stories/button.test.js
testHeading: "UI icon (larger)",
content: Template({
...args,
// UI icon that is larger than workflow sizing:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar thinking here. ✨

@castastrophe castastrophe enabled auto-merge (squash) November 12, 2024 19:56
@castastrophe castastrophe merged commit 38b0b76 into main Nov 12, 2024
17 of 24 checks passed
@castastrophe castastrophe deleted the chore-static-color-tests branch November 12, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@5t3ph 5t3ph 5t3ph approved these changes

@cdransf cdransf cdransf approved these changes

Assignees

@castastrophe castastrophe

Labels
ready-for-review skip_vrt Add to a PR to skip running VRT (but still pass the action) testing Visual regression testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@castastrophe @cdransf @5t3ph