feat: use sidekick to get list of projects #95
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
| @@ -31,12 +31,12 @@ <h1>Admin Edit</h1> | |||
| <section class="form-field config-field"> | |||
| <div class="form-field org-field"> | |||
| <label for="org">Organization</label> | |||
| <input name="org" id="org" list="org-list" required /> | |||
| <input name="org" id="org" list="org-list" autocomplete="off" required /> | |||
There was a problem hiding this comment.
browser was autocompleting sites not in the org based on previous entry/submission, hence setting autocomplete="off" to prevent that confusion
| const lastOrg = projects.orgs[0]; | ||
| setFieldValue(org, lastOrg, 'storage'); | ||
| if (projects.sites && projects.sites[lastOrg]) { | ||
| const selectedOrg = setFieldValue(org, projects.orgs[0], 'storage'); |
There was a problem hiding this comment.
if an org was selected in previous population step, use that org. prevents adding sites to data list that are from a different org.
…doesn't seem to make that guarantee
|
re PSI check: desktop CLS will be fixed in a future PR (#103). The weird 4.7S FCP for Site query is I think mostly a one-off. it isn't the first time I've seen that happen with tools/labs, but it doesn't happen every time either (roughly 20% of the time or so it seems). unsure what to make of it exactly as there is no obvious cause. |
depends on adobe/aem-sidekick#468 which is in sidekick 7.4.0
Test URLs:
https://sk-projects--helix-labs-website--adobe.aem.live/tools/image-audit/index.html
https://sk-projects--helix-labs-website--adobe.aem.live/tools/admin-edit/index.html
https://sk-projects--helix-labs-website--adobe.aem.live/tools/page-status/index.html
https://sk-projects--helix-labs-website--adobe.aem.live/tools/site-admin/index.html
https://sk-projects--helix-labs-website--adobe.aem.live/tools/site-query/index.html