Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 20250310 #33

Merged
merged 4 commits into from
Mar 10, 2025
Merged

Release 20250310 #33

merged 4 commits into from
Mar 10, 2025

Conversation

g-sabharwal
Copy link
Collaborator

@g-sabharwal g-sabharwal commented Mar 10, 2025 •
edited
Loading

Description

In version of node >= 18, path.join expects actual path and not the file path. We were passing file path.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@g-sabharwal g-sabharwal requested a review from xerxovksi March 10, 2025 06:24
@g-sabharwal g-sabharwal merged commit 7562e2b into main Mar 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xerxovksi xerxovksi xerxovksi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g-sabharwal @xerxovksi