Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Biquad and replace with BlockBiquad #10213

Merged
merged 5 commits into from
Apr 1, 2025

Conversation

relic-se
Copy link

@relic-se relic-se commented Apr 1, 2025

Fixes #10061

  • Replace the deprecated synthio.Biquad with synthio.BlockBiquad (now named synthio.Biquad)
  • Remove synthio.Synthesizer.low_pass_filter, synthio.Synthesizer.high_pass_filter, and synthio.Synthesizer.band_pass_filter
  • Remove synthio.AnyBiquad from documentation
  • Coefficients from biquad_filter_state have been moved into synthio_biquad (biquad_filter_state is still used for input and output state)

These updates have been tested on a Waveshare RP2040-PiZero with the Waveshare WM8960 Audio HAT. I can share test code if needed.

For interest: @dhalbert @gamblor21

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but I'd appreciate testing and/or a look-over by a synthio user as well. Thanks.

@dhalbert dhalbert merged commit 279d7a8 into adafruit:main Apr 1, 2025
613 checks passed
@gamblor21
Copy link
Member

I'll try to test it out soon. Did any existing learn guides about synthio refer to these? I think some did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove original Biquad type from synthio
3 participants