Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix release notes links. Add diff link #366

Closed
wants to merge 3 commits into from

Conversation

FoamyGuy
Copy link
Contributor

@FoamyGuy FoamyGuy commented Dec 11, 2023

While using the new release automation I came across a few things in need of tweaking.

This change covers three main things:

  • fix the pip installation command in the release notes. It was previously incorrectly using the full shorthand library name which will not work with pip install it must have adafruit-circuitpython- preceding the library name. To solve this I changed the function to accept the shorthand name and then used that to create the pypi name and docs URL from it.
  • Remove an errant "main" chunk of code that was leftover from development. Prior to my other changes this had gone unnoticed because it didn't cause any trouble.
  • added the Github 'changes' link to the release notes that are posted. The link got printed into the terminal of the person running the release automation this makes it so that effectively the same link is put into the release notes.

@FoamyGuy
Copy link
Contributor Author

The latest commit adds one additional change which is adding timeout=30 to all requests function calls. Somewhere along the line this became one of the pylint checks and none of our calls used the timeout argument so all of them failed this check in pylint.

Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test this, but it all makes sense to me!

@FoamyGuy
Copy link
Contributor Author

closing in favor of #389

@FoamyGuy FoamyGuy closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants