Use all mask filter pairs #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jun 11, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP2515 to 1.1.5 from 1.1.4: > Merge pull request adafruit/Adafruit_CircuitPython_MCP2515#25 from karlfl/Use_All_Mask_Filter_Pairs Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90393 to 2.1.5 from 2.1.4: > Merge pull request adafruit/Adafruit_CircuitPython_MLX90393#40 from purepani/add_exit_before_rt Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90640 to 1.3.2 from 1.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_MLX90640#32 from adafruit/stemma_i2c Updating https://github.com/adafruit/Adafruit_CircuitPython_AirLift to 1.0.14 from 1.0.13: > Merge pull request adafruit/Adafruit_CircuitPython_AirLift#11 from dhalbert/fix-start-wifi Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 3.1.1 from 3.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#206 from SamantazFox/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #19
This is a simple approach to fixing the issue of not properly using all of the Masks and Filters available on the MCP2515. This update does the following.
As far as I can tell, the previous code was using the _masks_in_use array to store the mask register being used, not the actual mask value. The only purpose for this array seemed to be for checking the array length to determine how many masks were in use. By placing the actual mask value in the _masks_in_use array, we're able to also search for it so more than one filter can be paired with each mask. This change shouldn't affect the checks used to ensure the max number mask/filter pairs is enforced.
This change also expands the documentation for '.listen()', adding details on how to use the matches array to setup the masks and filters on the MCP2515 using this library.
I've tested this change on an RP2040 CAN Bus Feather