Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge top and onTop, so the position is flexible. #3

Closed
wants to merge 3 commits into from

Conversation

sharp
Copy link

@sharp sharp commented Jul 30, 2013

Merge top and onTop, so the position is flexible.

In the most time, user do not need popup exactly vertical align on middle of page

@galulex
Copy link
Member

galulex commented Jul 30, 2013

@SharpV Could you reproduce the bug here that makes you to do these changes please.

@sharp
Copy link
Author

sharp commented Jul 30, 2013

@galulex Hi, I realized that the problem is I did not add 'fixed: true' option , so if I scroll the window down, and click to popup, then the lazybox is beyond out of bound. After I read your code, I do not think it is one bug.

Now, I want to control the top position of lazybox, and ''top: 50' is perfect for me :)

@galulex
Copy link
Member

galulex commented Jul 30, 2013

@SharpV It is ok for me too but the ability to automatically calculate the top position must be here too. I pulled your repository to my demo and the position of lazybox was brocken. Developers should update the gem without breaking the application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants