Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced Starter Workflow for Synopsys Action #2300

Closed
wants to merge 4 commits into from

Conversation

sadmananik
Copy link
Contributor

Pre-requisites

  • Prior to submitting a new workflow, please apply to join the GitHub Technology Partner Program: partner.github.com/apply.

Please note that at this time we are only accepting new starter workflows for Code Scanning. Updates to existing starter workflows are fine.


Tasks

For all workflows, the workflow:

  • Should be contained in a .yml file with the language or platform as its filename, in lower, kebab-cased format (for example, docker-image.yml). Special characters should be removed or replaced with words as appropriate (for example, "dotnet" instead of ".NET").
  • Should use sentence case for the names of workflows and steps (for example, "Run tests").
  • Should be named only by the name of the language or platform (for example, "Go", not "Go CI" or "Go Build").
  • Should include comments in the workflow for any parts that are not obvious or could use clarification.
  • Should specify least privileged permissions for GITHUB_TOKEN so that the workflow runs successfully.

For CI workflows, the workflow:

  • Should be preserved under the ci directory.
  • Should include a matching ci/properties/*.properties.json file (for example, ci/properties/docker-publish.properties.json).
  • Should run on push to branches: [ $default-branch ] and pull_request to branches: [ $default-branch ].
  • Packaging workflows should run on release with types: [ created ].
  • Publishing workflows should have a filename that is the name of the language or platform, in lower case, followed by "-publish" (for example, docker-publish.yml).

For Code Scanning workflows, the workflow:

  • Should be preserved under the code-scanning directory.
  • Should include a matching code-scanning/properties/*.properties.json file (for example, code-scanning/properties/codeql.properties.json), with properties set as follows:
    • name: Name of the Code Scanning integration.
    • creator: Name of the organization/user producing the Code Scanning integration.
    • description: Short description of the Code Scanning integration.
    • categories: Array of languages supported by the Code Scanning integration.
    • iconName: Name of the SVG logo representing the Code Scanning integration. This SVG logo must be present in the icons directory.
  • Should run on push to branches: [ $default-branch, $protected-branches ] and pull_request to branches: [ $default-branch ]. We also recommend a schedule trigger of cron: $cron-weekly (for example, codeql.yml).

Some general notes:

  • This workflow must only use actions that are produced by GitHub, in the actions organization, or
  • This workflow must only use actions that are produced by the language or ecosystem that the workflow supports. These actions must be published to the GitHub Marketplace. We require that these actions be referenced using the full 40 character hash of the action's commit instead of a tag. Additionally, workflows must include the following comment at the top of the workflow file:
    # This workflow uses actions that are not certified by GitHub.
    # They are provided by a third-party and are governed by
    # separate terms of service, privacy policy, and support
    # documentation.
    
  • Automation and CI workflows should not send data to any 3rd party service except for the purposes of installing dependencies.
  • Automation and CI workflows cannot be dependent on a paid service or product.

@sadmananik sadmananik requested review from a team as code owners February 12, 2024 06:20
@github-actions github-actions bot added the code-scanning Related to workflows that show on the Code Scanning setup page label Feb 12, 2024
@sadmananik sadmananik changed the title Enhanced Starter Workflow for Synopsys Action: Modified Security Scan Product URL Environment Variable from Secret to Vars Enhanced Starter Workflow for Synopsys Action Feb 12, 2024
@sadmananik
Copy link
Contributor Author

sadmananik commented Feb 13, 2024

Hi @alexisabril, Can you please review this PR? Thanks.

Copy link
Contributor

@alexisabril alexisabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sadmananik,

What is the purpose for changing this workflow from secrets to vars? This would lose any security protection naturally offered in the secrets context.

@sadmananik
Copy link
Contributor Author

sadmananik commented Feb 14, 2024

Hi @sadmananik,

What is the purpose for changing this workflow from secrets to vars? This would lose any security protection naturally offered in the secrets context.

@alexisabril
URL inputs should be “vars” instead of “secrets” so that the links displayed in the console output are usable. As secrets the URL part is masked rendering the link invalid. URL's are not security concerns in this scenario. Hope it helps.

@sadmananik
Copy link
Contributor Author

Hi @alexisabril,

If there are no other concerns with this PR, could you please merge it? Our customers are eagerly awaiting this change.
Your assistance would be greatly appreciated.

Thanks.

@sadmananik
Copy link
Contributor Author

Hi @@alexisabril,

Any update on this?

@sadmananik sadmananik requested a review from a team as a code owner April 15, 2024 06:12
Copy link

This pull request has become stale and will be closed automatically within a period of time. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-scanning Related to workflows that show on the Code Scanning setup page no-pr-activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants