Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI : Use artisan command laravel workflows #2284

Merged

Conversation

cgarciagarcia
Copy link
Contributor

ci: use artisan command to run test, because this ci/laravel.yml does not work properly in laravel when uses Pest instead of PHPUnit

… not work properly in laravel when uses Pest instead of PHPUnit
@cgarciagarcia cgarciagarcia requested a review from a team as a code owner January 26, 2024 22:01
Copy link
Contributor

@alexisabril alexisabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cgarciagarcia for the PR!

Noting this as the recommended path for an agnostic way to invoke tests in Laravel.

From the Laravel docs: https://laravel.com/docs/11.x/testing#introduction

An ExampleTest.php file is provided in both the Feature and Unit test directories. After installing a new Laravel application, execute the vendor/bin/pest, vendor/bin/phpunit, or php artisan test commands to run your tests.

@cgarciagarcia
Copy link
Contributor Author

cgarciagarcia commented Mar 27, 2024

@alexisabril I'm glad to contribute the most fascinating framework to my thought. Let me know if someone else has to merge it, or if your approval is enough.🫱🏻‍🫲🏼

@cgarciagarcia cgarciagarcia requested a review from a team as a code owner March 30, 2024 17:03
@alexisabril alexisabril merged commit b53d05e into actions:main Apr 1, 2024
3 checks passed
@965022-oss
Copy link

#2284 (comment) #2284 Branch: main 965022-oss-patch1/SHA 3a95482282, label: ci/use artisan command to run tests Laravel workflows,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants