feat: Add support for .sdkmanrc file in java-version-file parameter
#736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m-file-major-minor-patch-with-dist` for `.sdkmanrc`
…-patch-with-dist` test to include the file name of the java-version-file that is used
gimlet2
approved these changes
Jan 26, 2025
|
@aparnajyothi-y @HarithaVattikuti sorry for the direct ping. Would it be possible for the team to take a look at the PR or at least provide some feedback any time soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add support for
.sdkmanrcfile injava-version-fileparameter, as well as tests and updated documentation related to the new feature.I've renamed one e2e test (setup-java-version-from-file-major-minor-patch-with-dist) to include the actual name of the file under test. Without it, there were many job runs with the same name (i.e. ${{ matrix.distribution }} version from file 'openjdk64-17.0.10' - ${{ matrix.os }}), making it quite difficult to find the appropriate ones to verify - and losing a key element of the test: the name of the
java-version-file.Related issue: #669
Check list: