Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Tags handling in build-image.ps1 #11458

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Update Tags handling in build-image.ps1 #11458

merged 1 commit into from
Jan 23, 2025

Conversation

shamil-mubarakshin
Copy link
Contributor

@shamil-mubarakshin shamil-mubarakshin commented Jan 23, 2025 •
edited
Loading

Description

Join-String cmdlt is not available in powershell 5.*. This PR replaces cmdlt with -join operator in build-image.ps1 script

Related issue: #11415

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

@shamil-mubarakshin shamil-mubarakshin merged commit e149fc6 into actions:main Jan 23, 2025
3 checks passed
@shamil-mubarakshin shamil-mubarakshin deleted the patch-build-image-script-01 branch January 23, 2025 12:57
@shamil-mubarakshin shamil-mubarakshin mentioned this pull request Jan 23, 2025
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexey-Ayupov Alexey-Ayupov Alexey-Ayupov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shamil-mubarakshin @Alexey-Ayupov