-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for label colours #685
base: main
Are you sure you want to change the base?
Conversation
6d4006d
to
10b72b3
Compare
@MaksimZhukov do you know if anyone would have any time to review this? |
@MaksimZhukov any update? Is it worth me resolving the conflicts? |
awaiting for this feature. |
I'm assuming that since the PR was approved, it's worth resolving the conflict. I'll do it ASAP @farhad-ris |
any update @overbit? |
@MaksimZhukov I think this will be super useful feature. Any plan to review this feature? 🙏 |
f1a3fbf
to
5a04e9c
Compare
@farhad-ris @seonWKim @cmflynn PR updated to support latest version of the code. Sorry for the long wait |
}); | ||
|
||
for (const [label, color] of labels) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
await Promise.all(labels.map(l => {
const [label, colour] = l;
if (color) {
return client.rest.issues.updateLabel({
owner: github.context.repo.owner,
repo: github.context.repo.repo,
name: label,
color: color?.replace('#', '')
});
}
})
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awaiting promises in loops is always nasty. From memory, promises awaited in for .. of
will be fired sequentially rather than in parallel, which is rarely what we want
Description:
Add support for colours for labels maintaining back compatibility with the current configuration file format and the new version that will permit to select colours
Related issue:
#76
Check list: