Added retry to submodule cloning #1636
Open
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blakezulla
approved these changes
Mar 2, 2024
|
This would be a good addition as even pulling from GitHub on a GH runner can have intermittent failures that would resolve on a retry. What more needs to be done with this PR to get it landed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using actions/checkout@v3 or v4 we experience intermittent failures on workflows cloning submodules. The failures result in following error:
unable to access <SUBMODULE REPO URL>: gnutls_handshake() failed: Error in the pull function.Our environment is primarily self hosted runners using the action_controller_runner,
Re-running the workflows failed steps resolves the issues every time we've tried it. This PR adds the same retry logic that is used with the normal fetch flow used by the actions/checkout action. I have verified this change resolves the intermittent failures and passes the format-check, lint, and test steps described in the test.yml workflow.