-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Navbar for deprecation fix, accessibility, and performance (Closes #291) #292
Open
amrit1004
wants to merge
12
commits into
accordproject:main
Choose a base branch
from
amrit1004:nav
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amrit <[email protected]> fixed dropdown on hover
Signed-off-by: Amrit <[email protected]>
Signed-off-by: Amrit <[email protected]>
Signed-off-by: Amrit <[email protected]>
Signed-off-by: Amrit <[email protected]>
Signed-off-by: Amrit <[email protected]>
Signed-off-by: Amrit <[email protected]>
Signed-off-by: Amrit <[email protected]>
…ith new Dropdown API Signed-off-by: Amrit <[email protected]>
✅ Deploy Preview for ap-template-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(navbar): update Navbar for deprecation fix, accessibility, and performance
Closes #291
This pull request updates the
Navbar
component to resolve the Ant Design Dropdownoverlay
prop deprecation, enhance accessibility with ARIA labels and keyboard navigation, optimize performance withuseMemo
and static styles, and improve type safety with TypeScript. It also introduces basic error handling for images and suggests better file organization.Changes
overlay
withmenu
in Dropdown components for Ant Design compatibility.aria-label
attributes to interactive elements and keyboard navigation support withrole
andtabIndex
.helpMenuItems
usinguseMemo
to prevent unnecessary re-renders.styles
object outside the component to improve performance.FC<NavbarProps>
andas const
for styles.onError
handler to the logoImage
component for basic error handling.Flags
menuConfig.ts
) are suggested but not fully implemented—consider follow-up work.Screenshots or Video
(Note: Replace with actual links if available)
Related Issues
Author Checklist
--signoff
option of git commit.main
fromfork:branchname
.