-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refractored Footer #289
Open
amrit1004
wants to merge
11
commits into
accordproject:main
Choose a base branch
from
amrit1004:foot
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refractored Footer #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amrit <[email protected]> fixed dropdown on hover
Signed-off-by: Amrit <[email protected]>
Signed-off-by: Amrit <[email protected]>
Signed-off-by: Amrit <[email protected]>
Signed-off-by: Amrit <[email protected]>
Signed-off-by: Amrit <[email protected]>
Signed-off-by: Amrit <[email protected]>
✅ Deploy Preview for ap-template-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @DianaLease |
Signed-off-by: Amrit <[email protected]>
Hey @DianaLease Pls look into this as it closes #291 issue and let me know is any problem Persists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(footer): enhance CustomFooter with TypeScript, accessibility, and performance improvements
Closes #284
This pull request enhances the
CustomFooter
component by introducing TypeScript interfaces, improving accessibility witharia-label
attributes, optimizing performance withuseMemo
, and centralizing styles into a reusable object. The changes improve code maintainability, user experience, and consistency while addressing previous issues with duplicated styles and lack of type safety.Changes
FooterLink
andFooterSection
) for type safety and better code organization.styles
object to eliminate duplication (e.g.,Join
button styles) and ensure consistency.useMemo
for memoizingfooterSections
to optimize performance.aria-label
attributes to social media links for improved accessibility.Flags
FOOTER_SECTION
JSON file aligns with the new TypeScript interfaces; minor adjustments might be needed if the structure differs.Screenshots or Video
Related Issues
Author Checklist
--signoff
option of git commit.main
fromfork:foot
.