Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): Size of Agreement HTML modal - I287 #288

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

akshatbatra
Copy link

@akshatbatra akshatbatra commented Mar 18, 2025

Closes #287

The full screen modal view of Agreement HMTL window has larger size than required due to which a scrollbar appears. Height of Agreement HTML has been adjusted so that the modal fits the screen.

Changes

  • Height of Agreement HTML now depends upon whether it is rendered inside modal or not.

Screenshots or Video

Before:

Modal.Scroll.webm

After:

Modal.Scroll.Fixed.webm

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@akshatbatra akshatbatra requested a review from a team as a code owner March 18, 2025 14:54
Copy link

netlify bot commented Mar 18, 2025

Deploy Preview for ap-template-playground ready!

Name Link
🔨 Latest commit cb61675
🔍 Latest deploy log https://app.netlify.com/sites/ap-template-playground/deploys/67d989421b9d2c0008f854c6
😎 Deploy Preview https://deploy-preview-288--ap-template-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@akshatbatra
Copy link
Author

@sanketshevkar @DianaLease
Kindly see if this quick fix can be merged. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overflowing size of Agreement HTML modal
1 participant