Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Add auto-pairing for curly braces in Concerto model #281

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

surya4419
Copy link
Contributor

Closes #280

This PR adds an automatic pairing feature for curly braces {} in the Concerto model section within the Monaco Editor. This improves the editing experience by reducing syntax errors and ensuring balanced brace structures.

Changes

  • Implemented auto-insertion of closing braces when an opening brace { is typed
  • Ensured proper indentation and cursor positioning for multi-line brace pairs
  • Supported nested brace structures in the Concerto model section
  • Prevented auto-pairing inside strings and comments
  • Added a configuration option to enable/disable this feature

Screenshots or Video

After Changes

Template.Playground.-.Google.Chrome.2025-03-17.20-11-25.mp4

Related Issues

Author Checklist

it-works) for your commits using the --signoff option of git commit.

  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

Sorry, something went wrong.

@surya4419 surya4419 requested a review from a team as a code owner March 17, 2025 14:44
Copy link

netlify bot commented Mar 17, 2025

Deploy Preview for ap-template-playground ready!

Name Link
🔨 Latest commit bfcaf94
🔍 Latest deploy log https://app.netlify.com/sites/ap-template-playground/deploys/67e193937844a700085b564f
😎 Deploy Preview https://deploy-preview-281--ap-template-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@surya4419
Copy link
Contributor Author

Hey @DianaLease , when you have some time, could you please review my PR? I'd love to get your feedback. Thanks!

Copy link
Member

@sanketshevkar sanketshevkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution. Can you please rebase your branch?

@surya4419 surya4419 force-pushed the surya4419/i280/Auto-Pairing-Curly-Braces-in-Concerto-Model branch from 1cfc302 to 0b28208 Compare March 17, 2025 17:33
@surya4419
Copy link
Contributor Author

You're welcome! I've rebased my branch as requested. Please review my PR when you get a chance and let me know if any further changes are needed.

LGTM. Thanks for the contribution. Can you please rebase your branch?

You're welcome! @sanketshevkar I've rebased my branch as requested. Please review my PR when you get a chance and let me know if any further changes are needed.

@surya4419 surya4419 force-pushed the surya4419/i280/Auto-Pairing-Curly-Braces-in-Concerto-Model branch from 0b28208 to 0d95a91 Compare March 19, 2025 11:05
@surya4419
Copy link
Contributor Author

@sanketshevkar Thank you for reviewing my PR! Since you've approved my changes, could you please merge it when you get a chance?

…n selection (accordproject#318)

Signed-off-by: surya4419 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request 🛍️: Auto-Pairing Curly Braces in Concerto Model Section
2 participants