feat(editor): add resizable editor/preview panes #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ap-template-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hey @DianaLease , when you have some time, could you please review my PR? I'd love to get your feedback. Thanks! |
sanketshevkar
requested changes
Mar 17, 2025
…lity Signed-off-by: surya4419 <[email protected]>
…lity Signed-off-by: surya4419 <[email protected]>
…cordproject#259) * fix(full-reload): Replace <a> tag with <Link> tag to prevent full reloading (accordproject#250) Signed-off-by: Sahil Khan <[email protected]> * fix(full-reload): rel attribute is unnecessary for internal links (accordproject#250) Signed-off-by: Sahil Khan <[email protected]> * fix(full-reload): Replace <a> tag with <Link> tag to prevent full reloading (accordproject#258) Signed-off-by: Sahil Khan <[email protected]> * fix(full-reload): rel attribute is unnecessary for internal links (accordproject#258) Signed-off-by: Sahil Khan <[email protected]> --------- Signed-off-by: Sahil Khan <[email protected]> Signed-off-by: surya4419 <[email protected]>
…roject#189) * components es-lint and type fixed Signed-off-by: nitro56565 <[email protected]> * updated arrow function for tour.start Signed-off-by: nitro56565 <[email protected]> --------- Signed-off-by: nitro56565 <[email protected]> Signed-off-by: surya4419 <[email protected]>
surya4419
force-pushed
the
surya4419/i234/Add-Resizable-Editor-Preview-Panes
branch
from
2d8645b to
aea37ef
Compare
|
Hi @sanketshevkar ,Thanks for the feedback! I have removed the resize option on mobile, as we are not optimizing for mobile views at the moment. Please check the latest preview deployment and let me know your thoughts! |
…oject#195) Signed-off-by: Yashsaraswat2004 <[email protected]> Signed-off-by: surya4419 <[email protected]>
…ding area. (accordproject#243) * Formated the code for future use with code maintainability. Signed-off-by: Owaise Imdad <[email protected]> * Fab global is added. Signed-off-by: Owaise Imdad <[email protected]> --------- Signed-off-by: Owaise Imdad <[email protected]> Signed-off-by: surya4419 <[email protected]>
* fix(button): fix dark mode toggle click - I201 Signed-off-by: Dharma Teja <[email protected]> * fix(button): fix dark mode toggle click - I201 Signed-off-by: Dharma Teja <[email protected]> * fix(button): fix dark mode toggle click - I201 Signed-off-by: Dharma Teja <[email protected]> * update is checked Signed-off-by: Dharma Teja <[email protected]> * feat(editor): add undo redo icons to editor - I204 Signed-off-by: Dharma Teja <[email protected]> * feat(editor): add undo redo icons to editor - I204 Signed-off-by: Dharma Teja <[email protected]> * feat(editor): add undo redo icons to editor - I204 Signed-off-by: Dharma Teja <[email protected]> * feat(editor): add undo redo icons to editor - I204 Signed-off-by: Dharma Teja <[email protected]> * feat(editor): add undo redo icons to editor - I204 Signed-off-by: Dharma Teja <[email protected]> * feat(editor): add undo redo icons to editor - I204 Signed-off-by: Dharma Teja <[email protected]> --------- Signed-off-by: Dharma Teja <[email protected]> Signed-off-by: surya4419 <[email protected]>
Signed-off-by: surya4419 <[email protected]>
surya4419
force-pushed
the
surya4419/i234/Add-Resizable-Editor-Preview-Panes
branch
from
e220bc5 to
5e17e49
Compare
|
Hey @sanketshevkar @DianaLease , when you have some time, could you please review my PR? I'd love to get your feedback. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #234
This PR implements a resizable editor and preview pane feature, similar to LeetCode's interface. Users can now adjust the width of the editor and preview panes by dragging a divider between them. The preferred pane sizes are saved in local storage, ensuring persistence across sessions.
Changes
Screenshots or Video
After changes
Template.Playground.-.Personal.-.Microsoft_.Edge.2025-03-17.18-23-49.mp4
Related Issues
Author Checklist
--signoffoption of git commit.mainfromfork:branchname