Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting feature across all Monaco-based editors #275

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

teja-pola
Copy link
Contributor

@teja-pola teja-pola commented Mar 17, 2025

Closes #274

Changes

  • Implemented the formatting feature for all Monaco-based editors (ConcertoEditor, TemplateMark, JSONEditor).
  • Used monaco.editor.getEditors() to retrieve all editor instances and apply formatting.
  • Ensured the format button (FaMagic icon) is aligned properly in the UI for all editors.
  • Handled cases where Monaco might not be loaded yet to prevent runtime errors.

Flags

n/a

Screenshots or Video

Untitled.video.-.Made.with.Clipchamp.4.mp4

Related Issues

Packages added:

remark (^15.0.1) – A markdown parser and transformer for JavaScript, used for processing markdown content efficiently. Remark GitHub
rehype-highlight (^7.0.0) – A plugin for rehype that adds syntax highlighting to code blocks in markdown. Rehype-Highlight GitHub
rehype-raw (^7.0.0) – Enables raw HTML processing inside markdown while ensuring safe output. Rehype-Raw GitHub
regenerator-runtime (^0.13.11) – Provides support for async/await and generator functions, ensuring cross-environment compatibility. Regenerator GitHub
remark-parse (^10.0.0) - A parser that converts markdown into an Abstract Syntax Tree (AST) for further processing.
GitHub: remarkjs/remark-parse
remark-stringify (^10.0.0) - A plugin for converting markdown AST back into a string format, useful for formatting markdown output.
GitHub: remarkjs/remark-stringify

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@teja-pola teja-pola requested a review from a team as a code owner March 17, 2025 10:37
Copy link

netlify bot commented Mar 17, 2025

Deploy Preview for ap-template-playground ready!

Name Link
🔨 Latest commit 1db8d3b
🔍 Latest deploy log https://app.netlify.com/sites/ap-template-playground/deploys/67d7fcdede26ad0008d5f0aa
😎 Deploy Preview https://deploy-preview-275--ap-template-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@sanketshevkar sanketshevkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a much needed feature. Can you help us with a few more details about the packages being added and their usage in this project?

@teja-pola
Copy link
Contributor Author

This seems like a much needed feature. Can you help us with a few more details about the packages being added and their usage in this project?

Added. Please review and let me know if any more details are needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Formatting Support for All Editors in Monaco Editor
2 participants