Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Navbar): replaced deprecated overlay prop with menu in Dropdown #178 #273

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

codeAntu
Copy link

@codeAntu codeAntu commented Mar 17, 2025

Closes #

Changes

  • Replaced deprecated overlay prop with menu in Dropdown

Flags

Screenshots or Video

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@codeAntu codeAntu requested a review from a team as a code owner March 17, 2025 05:40
Copy link

netlify bot commented Mar 17, 2025

Deploy Preview for ap-template-playground ready!

Name Link
🔨 Latest commit 3786f71
🔍 Latest deploy log https://app.netlify.com/sites/ap-template-playground/deploys/67d9cd456aa4b50008a7895c
😎 Deploy Preview https://deploy-preview-273--ap-template-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@sanketshevkar sanketshevkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please undo the formatting changes and keep the PR target to your changes?

Also can you also share if ant has issues any deprecation notice for the overlay prop?

Thanks!

@codeAntu
Copy link
Author

I’ve reverted the formatting changes to keep the PR focused. I think this might help: Ant Design Pro Components Issue #6162, where AntD discusses the overlay prop deprecation. Let me know if anything else is needed!

@codeAntu codeAntu requested a review from sanketshevkar March 17, 2025 20:04
@codeAntu codeAntu force-pushed the codeantu/i178/antd-dropdown-menu-fix branch from 951db36 to 66b3274 Compare March 18, 2025 17:07
codeAntu and others added 7 commits March 19, 2025 01:12
…cordproject#259)

* fix(full-reload): Replace <a> tag with <Link> tag to prevent full reloading (accordproject#250)

Signed-off-by: Sahil Khan <[email protected]>

* fix(full-reload): rel attribute is unnecessary for internal links (accordproject#250)

Signed-off-by: Sahil Khan <[email protected]>

* fix(full-reload): Replace <a> tag with <Link> tag to prevent full reloading (accordproject#258)

Signed-off-by: Sahil Khan <[email protected]>

* fix(full-reload): rel attribute is unnecessary for internal links (accordproject#258)

Signed-off-by: Sahil Khan <[email protected]>

---------

Signed-off-by: Sahil Khan <[email protected]>
Signed-off-by: Ananta <[email protected]>
…roject#189)

* components es-lint and type fixed

Signed-off-by: nitro56565 <[email protected]>

* updated arrow function for tour.start

Signed-off-by: nitro56565 <[email protected]>

---------

Signed-off-by: nitro56565 <[email protected]>
Signed-off-by: Ananta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants