-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Navbar): replaced deprecated overlay prop with menu in Dropdown #178 #273
base: main
Are you sure you want to change the base?
fix(Navbar): replaced deprecated overlay prop with menu in Dropdown #178 #273
Conversation
✅ Deploy Preview for ap-template-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…omponent Signed-off-by: Ananta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please undo the formatting changes and keep the PR target to your changes?
Also can you also share if ant
has issues any deprecation notice for the overlay prop?
Thanks!
I’ve reverted the formatting changes to keep the PR focused. I think this might help: Ant Design Pro Components Issue #6162, where AntD discusses the overlay prop deprecation. Let me know if anything else is needed! |
Signed-off-by: Ananta <[email protected]>
951db36
to
66b3274
Compare
…omponent Signed-off-by: Ananta <[email protected]>
…cordproject#259) * fix(full-reload): Replace <a> tag with <Link> tag to prevent full reloading (accordproject#250) Signed-off-by: Sahil Khan <[email protected]> * fix(full-reload): rel attribute is unnecessary for internal links (accordproject#250) Signed-off-by: Sahil Khan <[email protected]> * fix(full-reload): Replace <a> tag with <Link> tag to prevent full reloading (accordproject#258) Signed-off-by: Sahil Khan <[email protected]> * fix(full-reload): rel attribute is unnecessary for internal links (accordproject#258) Signed-off-by: Sahil Khan <[email protected]> --------- Signed-off-by: Sahil Khan <[email protected]> Signed-off-by: Ananta <[email protected]>
…roject#189) * components es-lint and type fixed Signed-off-by: nitro56565 <[email protected]> * updated arrow function for tour.start Signed-off-by: nitro56565 <[email protected]> --------- Signed-off-by: nitro56565 <[email protected]> Signed-off-by: Ananta <[email protected]>
…oject#195) Signed-off-by: Yashsaraswat2004 <[email protected]>
Signed-off-by: Ananta <[email protected]>
Signed-off-by: Ananta <[email protected]>
….com/codeAntu/template-playground into codeantu/i178/antd-dropdown-menu-fix
Closes #
Changes
Flags
Screenshots or Video
Related Issues
Author Checklist
--signoff
option of git commit.main
fromfork:branchname