Fix: CTO format as an optional model description #17 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chibuezem Marvinrose <[email protected]>
Signed-off-by: Chibuezem Marvinrose <[email protected]>
Signed-off-by: Chibuezem Marvinrose <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves issue #17 by enabling the /templates POST endpoint in the Accord Project Agreement Protocol to accept a CTO string as an optional alternative to a structured model within the templateModel object. The server now parses the cto field into a [email protected] using @accordproject/concerto-core’s ModelManager, enhancing flexibility for users defining template models.
Key changes include:
Updated index.ts to parse cto strings in the createTemplate handler, ensuring a fresh ModelManager instance per request and returning the parsed model.
Modified openapi.json to include cto as an optional property in the TemplateModel schema.
Revised Specification.md and index.md to document the new feature.
Testing Postman confirms successful parsing, with the response including the parsed model. This maintains backward compatibility while meeting the requirements.
Unit Test: npm test -- tests/create-template.test.ts passes:
