Change Assembly Version to AssemblyVersion in win_pe

[alok1304]

Fixes #3790

Tasks

• Reviewed contribution guidelines
• PR is descriptively titled 📑 and links the original issue above 🔗
• Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
  Run tests locally to check for errors.
• Commits are in uniquely-named feature branch and has no merge conflicts 📁
• Updated documentation pages (if applicable)
• Updated CHANGELOG.rst (if applicable)

Signed-off-by: Alok Kumar [email protected]

[alok1304]

@pombredanne two test cases are failing when I used AssemblyVersion for
test_win_pe_Moq_Silverlight_dll and
test_win_pe_microsoft_practices_enterpriselibrary_caching_dll in test_win_pe.py

it shows (I checked for test_win_pe_Moq_Silverlight_dll)

>       assert result == expected
E       AssertionError: assert {'AssemblyVer...y': None, ...} == {'AssemblyVer...y': None, ...}
E
E         Omitting 20 identical items, use -vv to show
E         Differing items:
E         {'extra_data': {'Assembly Version': '4.2.1507.118'}} != {'extra_data': {}}
E         Use -v to get more diff

it shows that the result dictionary contains an extra_data field with {'Assembly Version': '4.2.1507.118'} that means extra_data field contains Assembly Version.

I think no need to change this 'Assembly Version' to 'AssemblyVersion' because extra_data field already contains
Assembly Version.

I think we should not handle the correct Windows PE versions when we using AssemblyVersion in #3790.
@pombredanne Am I Right??

[pombredanne]

Both "Assembly Version" and "AssemblyVersion" exist in the wild. See the your updated tests that are skipping this value now.
This is not correct:
https://github.com/aboutcode-org/scancode-toolkit/pull/4116/files#diff-912e6b6b9ff4c33ea88d4f914e955f723fb024e17161592bfc2a2124718db218L5

You cannot replace one with the other, if need be you need both, if you can find a tiny test PE that actually contains "AssemblyVersion".
See https://github.com/search?q=["Assembly+Version"]+language%3AC%23&type=code

[alok1304]

Hey @pombredanne

You cannot replace one with the other, if need be you need both, if you can find a tiny test PE that actually contains "AssemblyVersion".

I use both "Assembly Version" and "AssemblyVersion" Now it is working and also all test cases are passed.

[AyanSinhaMahapatra]

@alok1304 see #4116 (review) you need to add a minimal test with a real example to test this functionality. Look for test files similar to what we have, do you need any help finding these?

[alok1304]

Look for test files similar to what we have, do you need any help finding these?

yes, I need help, how do we find these files for the test that contains AssemblyVersion?