Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for net8.0 #18

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

markwgit
Copy link

  • Updated the projects and added support for net8.0
  • Updated nuspec file and readme.
  • Updated test project to run on net8.0.

- Updated the projects and added support for net8.0
- Updated nuspec file and readme.
- Updated test project to run on net8.0.
@aboo
Copy link
Owner

aboo commented Dec 30, 2024

@markwgit thanks for the PR. The build for PR failed. I believe .github/workflows/pullrequest.yml

should use net 8 to build

name: Pull Request CI
on:
  pull_request:
    branches:
      - master
jobs:
  build:
    name: Build and Test
    runs-on: windows-latest
    steps:
      - name: Checkout repo
        uses: actions/checkout@v2
      - uses: actions/setup-dotnet@v1
        with:
          dotnet-version: '8.0.x'
      - name: Build project
        run: dotnet build azure-documentdb-odata-sql.sln
      - name: Run tests
        run: dotnet test azure-documentdb-odata-sql.sln

@markwgit
Copy link
Author

@aboo, I update deployment.yml and pullrequest.yml files.

@markwgit markwgit marked this pull request as draft December 30, 2024 15:08
@markwgit
Copy link
Author

@aboo,
I changed PR to draft.
Please don't close it.

We have some issue with 2 tests after we upgrade Microsoft.AspNetCore.OData to 9.1.1
Test for example: TranslateAnyToJoin_WhenThereIsOneNestedjoinWithComplexPath

@markwgit
Copy link
Author

markwgit commented Jan 1, 2025

Hi @aboo ,

I tried investigate the issues with 2 tests. The issue does not related to .NET8.
Its can be reproduced just after update of Microsoft.AspNetCore.OData to 8.2.4 version.

FOr example, the Cosmos DB query in test "TranslateAnyToJoin_WhenThereIsOneNestedjoinWithComplexPath" is generated incorrectly:
Invalid query: SELECT VALUE c FROM c JOIN l IN c.payload.bet.legs JOIN o IN l.legs.outcomes WHERE o.id = 'test'
Correct query: SELECT VALUE c FROM c JOIN l IN c.payload.bet.legs JOIN o IN l.outcomes WHERE o.id = 'test'

Could you please look on this issue or may be forfard this issue to relevant person?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants