Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lint): remove redundant nolint #229

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

abemedia
Copy link
Owner

No description provided.

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.49%. Comparing base (933d7bc) to head (a1c9cd4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #229   +/-   ##
=======================================
  Coverage   98.49%   98.49%           
=======================================
  Files          24       24           
  Lines         732      732           
=======================================
  Hits          721      721           
  Misses          6        6           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Benchmark Results

decoder
goos: linux
goarch: amd64
pkg: github.com/abemedia/go-don/decoder
cpu: AMD EPYC 7763 64-Core Processor                
          │   before    │             after             │
          │   sec/op    │   sec/op     vs base          │
Decoder-4   762.1n ± 3%   759.9n ± 1%  ~ (p=0.912 n=10)

          │   before   │             after              │
          │    B/op    │    B/op     vs base            │
Decoder-4   176.0 ± 0%   176.0 ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal

          │   before   │             after              │
          │ allocs/op  │ allocs/op   vs base            │
Decoder-4   3.000 ± 0%   3.000 ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal

@abemedia abemedia merged commit f6ec7a4 into master Sep 27, 2024
11 checks passed
@abemedia abemedia deleted the chore/remove-nolint branch September 27, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant