Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add local storage cache #312

Merged
merged 5 commits into from
Jan 15, 2024
Merged

Conversation

qiweiii
Copy link
Contributor

@qiweiii qiweiii commented Dec 26, 2023

resolve: #293

  • added a db that use local storage in helios-ts

Not sure how to test this, I tried to run the run.sh but there is network error, it could be my network problem since I am using a vpn

image

@ncitron
Copy link
Collaborator

ncitron commented Jan 8, 2024

Hmm yeah that is a strange error. Will try testing myself to see if it works on my machine.

Copy link
Collaborator

@ncitron ncitron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Copy link
Collaborator

@ncitron ncitron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple last comments.

Once this is done can you make sure that CI is passing (fmt, clippy, test) and then I think we are good to merge.

Copy link
Collaborator

@ncitron ncitron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome work!

@ncitron ncitron merged commit 63dc560 into a16z:master Jan 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add database that uses browser local storage for caching checkpoints
2 participants