Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove forceful precomputation behaviour; Improvements to data loading #303

Merged
merged 7 commits into from
Mar 8, 2025
Merged

Remove forceful precomputation behaviour; Improvements to data loading #303

merged 7 commits into from
Mar 8, 2025

Conversation

a-r-r-o-w
Copy link
Owner

@a-r-r-o-w a-r-r-o-w commented Mar 7, 2025 •
edited
Loading

Fixes #296 and #295.

Adds a --enable_precomputation flag. It is disable by default to that one can train normally without saving/loading from disk.

Adds some basic sanity-checking tests.

TODO:

  • update all existing examples to use --enable_precomputation since that was the default behaviour with them, and do a quick test
  • update docs

cc @tau-yihouxiang @dorpxam

@a-r-r-o-w a-r-r-o-w mentioned this pull request Mar 8, 2025
Merged
@a-r-r-o-w a-r-r-o-w merged commit 41c3c40 into main Mar 8, 2025
1 check passed
@a-r-r-o-w a-r-r-o-w deleted the feature/remove-forceful-precomputation-behaviour branch March 8, 2025 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support training without precomputation
1 participant
@a-r-r-o-w