[Chore] reset unnecessary args #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think a better solution might be to only log relevant arguments based on training type, no? Would add a utility function like |
|
Will work on that and mark it ready for review when ready. |
|
@a-r-r-o-w do the latest changes work for you? Full-finetune logging: https://wandb.ai/sayakpaul/finetrainers-cog/runs/bzrif246/overview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
training_type == "full-finetune", I think we should reset the default values of LoRA related args likelora_alpha,rank, etc. Otherwise, the logged args in the tracker might be confusing for the users.No need to explain if this is not right, I will close the PR. Thought of directly opening a PR as it was easier and not time-consuming at all.
Example overview: https://wandb.ai/sayakpaul/finetrainers-cog/runs/t1c5jcj3/overview.