Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update requirements #189

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Update requirements #189

merged 3 commits into from
Jan 7, 2025

Conversation

a-r-r-o-w
Copy link
Owner

Fix #186

@a-r-r-o-w a-r-r-o-w requested a review from sayakpaul January 7, 2025 00:17
sayakpaul
sayakpaul reviewed Jan 7, 2025
View reviewed changes
requirements.txt
@@ -1,16 +1,16 @@
accelerate
bitsandbytes
diffusers>=0.30.3
diffusers>=0.32.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we always tell users to install from the main. I think we do tell that in the README.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

sayakpaul
sayakpaul reviewed Jan 7, 2025
View reviewed changes
requirements.txt
torchao>=0.5.0
torch>=2.5.1
torchvision>=0.20.1
torchao>=0.7.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR. But I would like to make it so that torchao is installed only when it's required by the user. I will work on it.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that works. We currently don't support torchao in the new API either, so can be addressed together in near future

sayakpaul
sayakpaul approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny comment but otherwise, LGTM!

@sayakpaul sayakpaul mentioned this pull request Jan 7, 2025
Closed
2 tasks
@a-r-r-o-w a-r-r-o-w merged commit f1b0296 into main Jan 7, 2025
1 check passed
@a-r-r-o-w a-r-r-o-w deleted the update-requirements branch January 7, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayakpaul sayakpaul sayakpaul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

requirements torch<2.5.0 vs torch 2.5.1
2 participants
@a-r-r-o-w @sayakpaul