Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Removed the hardcoded HTTP scheme and port to allow the user to… #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Hector-Work
Copy link

Removed the hardcoded HTTP scheme and port to allow the user to decide what they want to use. Currently, HTTPS URIs are changed to HTTP, which can prevent communication with the printer.

Recently experienced this on a Windows Print Server where SSL was required. Took a while to work out why the request was failing, but eventually found the scheme hardcoded in the library. Removing it allowed me to specify HTTPS in the server's address.

… decide what they want to use. Currently, HTTPS URIs are changed to HTTP, which can prevent communication with the printer.
This was referenced Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants