Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on MacCatalyst #37

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

hossinasaadi
Copy link

fix build codeEditor for MacCatalyst
not find module 'CodeEditor' for target 'x86_64-apple-ios-macabi';

@SoylentGraham
Copy link

I have some similar changes in #36

... which I now see I never submitted a PR for :)

@hossinasaadi
Copy link
Author

I have some similar changes in #36

... which I now see I never submitted a PR for :)

Yeah, today i faced this issue and i felt like i should submit a PR for that too :)

@helje5
Copy link
Member

helje5 commented Mar 9, 2025

This seems to replace NSColor w/ Color, which looks incorrect? It should be UIColor on UIKit and stay as NSColor on AppKit.
A proper fix would likely have to adjust the #if os(macOS) guards to deal with Catalyst.

@SoylentGraham
Copy link

Why use UIColor, NSColor, and loads of macros... when you can use SwiftUi's Color in a SwiftUi API.

(Ps, dont use if(macos), use #if canimport(appkit) )

@hossinasaadi
Copy link
Author

@helje5 Now should works properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants