Added magento/magento-coding-standard to keep closer to Magento standards #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to avoid collision with upstream Magento2 coding standard. This is a breaking change and will require a new major version number when it is released.
This is feasible as we are releasing the next major version of this pacakge anyway. (See previous commit.)
Use official Magento2 coding standard as base for YouweMagento2
…are not declared.
…ards. * Added support for phtml templates. * Added Fisheye coding standards. * Updated current rules and added comments why it was added.
leonhelmus
requested review from
fredden,
rutgerrademaker,
jitze,
Anve94,
igorwulff,
Epo123,
DuckThom and
jasperzeinstra
fredden
approved these changes
Sep 26, 2022
There was a problem hiding this comment.
I'm not sure about the paths in the scripts section of composer.json, but will defer to / trust @leonhelmus who has tested this.
All other changes since I worked on this look good.
Epo123
approved these changes
Sep 26, 2022
DuckThom
approved these changes
Sep 26, 2022
| @@ -1,22 +1,33 @@ | |||
| { | |||
| "name": "youwe/coding-standard-magento2", | |||
| "description": "Youwe PHP Coding Standard for Magento2", | |||
| "type": "phpcs-sniffs", | |||
| "homepage": "https://github.com/YouweGit/coding-standard-magento2", | |||
| "license": "proprietary", | |||
There was a problem hiding this comment.
Not blocking, but maybe a good idea to change this to a different license in the future as the code is open source and not proprietary.
Automatically update/set installed_paths for phpcs
…taller to add it to installed paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
The version v25 is used as a base. If not compatible please update the
phpcs.xmlin project root.Removed