Skip to content

Commit

Permalink
Merge pull request #11900 from Yoast/replace-pe-premium-page-with-uni…
Browse files Browse the repository at this point in the history
…que-versions

Make Go Premium links more unique
  • Loading branch information
IreneStr authored Dec 21, 2018
2 parents 414fd5c + 0513481 commit 3d2ec40
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 9 deletions.
2 changes: 1 addition & 1 deletion admin/metabox/class-metabox.php
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ private function get_advanced_meta_section() {
private function get_buy_premium_link() {
return sprintf( '<div class="%1$s"><a target="_blank" rel="noopener noreferrer" href="%2$s"><span class="dashicons dashicons-star-filled wpseo-buy-premium"></span>%3$s</a></div>',
'wpseo-metabox-buy-premium',
esc_url( WPSEO_Shortlinker::get( 'https://yoa.st/pe-premium-page' ) ),
esc_url( WPSEO_Shortlinker::get( 'https://yoa.st/3g6' ) ),
__( 'Go Premium', 'wordpress-seo' )
);
}
Expand Down
2 changes: 1 addition & 1 deletion admin/taxonomy/class-taxonomy-metabox.php
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ private function get_buy_premium_section() {
WPSEO_Shortlinker::get( 'https://yoa.st/pe-buy-premium' ),
/* translators: %s expands to Yoast SEO Premium. */
sprintf( __( 'Get %s', 'wordpress-seo' ), 'Yoast SEO Premium' ),
WPSEO_Shortlinker::get( 'https://yoa.st/pe-premium-page' ),
WPSEO_Shortlinker::get( 'https://yoa.st/3g5' ),
__( 'More info', 'wordpress-seo' )
);

Expand Down
15 changes: 8 additions & 7 deletions admin/views/licenses.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,13 @@
'wordpress-seo-premium',
new WPSEO_Extension(
array(
'url' => WPSEO_Shortlinker::get( 'https://yoa.st/pe-premium-page' ),
'title' => 'Yoast SEO Premium',
'buyUrl' => WPSEO_Shortlinker::get( 'https://yoa.st/zz' ),
'infoUrl' => WPSEO_Shortlinker::get( 'https://yoa.st/zy' ),
'title' => 'Yoast SEO Premium',
/* translators: %1$s expands to Yoast SEO */
'desc' => sprintf( __( 'The premium version of %1$s with more features & support.', 'wordpress-seo' ), 'Yoast SEO' ),
'image' => plugins_url( 'images/extensions-premium-ribbon.png?v=' . WPSEO_VERSION, WPSEO_FILE ),
'benefits' => array(),
'desc' => sprintf( __( 'The premium version of %1$s with more features & support.', 'wordpress-seo' ), 'Yoast SEO' ),
'image' => plugins_url( 'images/extensions-premium-ribbon.png?v=' . WPSEO_VERSION, WPSEO_FILE ),
'benefits' => array(),
)
)
);
Expand Down Expand Up @@ -188,14 +189,14 @@

<?php else : ?>

<a target="_blank" href="<?php WPSEO_Shortlinker::show( 'https://yoa.st/zz' ); ?>" class="yoast-button-upsell"><?php
<a target="_blank" href="<?php echo esc_url( $extension->get_buy_url() ); ?>" class="yoast-button-upsell"><?php
/* translators: $1$s expands to Yoast SEO Premium */
printf( __( 'Buy %1$s', 'wordpress-seo' ), $extension->get_title() );
echo $new_tab_message;
echo '<span aria-hidden="true" class="yoast-button-upsell__caret"></span>';
?></a>

<a target="_blank" href="<?php WPSEO_Shortlinker::show( 'https://yoa.st/zy' ); ?>" class="yoast-link--more-info">
<a target="_blank" href="<?php echo esc_url( $extension->get_info_url() ); ?>" class="yoast-link--more-info">
<?php
printf(
/* translators: Text between %1$s and %2$s will only be shown to screen readers. %3$s expands to the product name. */
Expand Down

0 comments on commit 3d2ec40

Please sign in to comment.