Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix meshctrl addusertodevicegroup arguments #6504

Closed
wants to merge 1 commit into from

Conversation

ijustw0rkhere
Copy link
Contributor

No description provided.

@si458
Copy link
Collaborator

si458 commented Nov 10, 2024

this doesnt need fixing unless you can explain the change
the serverside code already converts usernames to userids

 // Convert user names to userid's
if (command.userids == null) {
  command.userids = [];
  for (var i in command.usernames) {
    if (parent.users['user/' + domain.id + '/' + command.usernames[i].toLowerCase()] != null) { command.userids.push('user/' + domain.id + '/' + command.usernames[i].toLowerCase()); }
    else if (parent.users['user/' + domain.id + '/' + command.usernames[i]] != null) { command.userids.push('user/' + domain.id + '/' + command.usernames[i]); }
  }
}

@ijustw0rkhere
Copy link
Contributor Author

Ah, yep, you are correct....

This was supposed to be my first attempt at helping contribute so I figured I would start with something small. In classic fashion, I botched the attempt. This change was one of a few changes I have made in attempt to address some conformity issues in meshctrl. Unfortunately I grabbed one that was cosmetic rather than one that was impactful.

@si458
Copy link
Collaborator

si458 commented Nov 10, 2024

@ijustw0rkhere sure, no worries, keep at it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants