Replace moshi with kotlinx-serialization #152
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends on #136. There's still work to be so external input is more then welcome:
Changes that should be discussed:
ZonedDateTime
withInstant
from kotlinx-datetime - while this logically correct it does reduce all datetime representations to Zulu timezonenumber
fromBigDecimal
todouble
- there is no official kmp support forBigDecimal
which is not great becausedouble
is an approximationobject
withJsonObject
- while usingJson*
classes is more type-safe it does modify the API heavilyAs you can see most problems are around unsupported types which we could support via the Java classes but would still require some serialization changes maybe via contextual serialization?
The last problematic point is regarding nullability. While deserialization works as expected serialization implicitly omits
null
values. As far as I can tell these could be added back if the integrator passes inencodeDefaults
: true on theJsonConfiguration
. Thex-nullable
vendor extension just statesnull
as a valid value and doesn't imply the client should explicitly sendnull
to define a property as missing so maybe this is not actually a problem.