Skip to content

Commit

Permalink
disable react-transform-hmr for now, align to new babel6 requires nee…
Browse files Browse the repository at this point in the history
…ding default for those exporting
  • Loading branch information
bdefore committed Dec 21, 2015
1 parent 886d8ec commit 2e2901b
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 20 deletions.
20 changes: 7 additions & 13 deletions .babelrc
Original file line number Diff line number Diff line change
@@ -1,21 +1,15 @@
{
"presets": [
"es2015",
"stage-0",
"react"
],
"env": {
"development": {
"plugins": [
[
"react-transform", {
"transforms": [{
"transform": "react-transform-hmr",
"imports": ["react"],
"locals": ["module"]
}, {
"transform": "react-transform-catch-errors",
"imports": ["react", "redbox-react"]
}]
}
],
[ "transform-runtime" ],
[ "typecheck" ]
[ "typecheck" ],
[ "transform-decorators-legacy" ]
]
}
}
Expand Down
2 changes: 1 addition & 1 deletion config/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ var CleanPlugin = require('clean-webpack-plugin');
var ExtractTextPlugin = require('extract-text-webpack-plugin');
var strip = require('strip-loader');

var babelConfig = 'babel-loader?presets[]=es2015,presets[]=stage-0,presets[]=react'
var babelConfig = 'babel-loader?presets[]=es2015,presets[]=stage-0,presets[]=react,plugins[]=transform-runtime,plugins[]=transform-decorators-legacy'
if (process.env.NODE_ENV !== 'production') {
var jsLoaders = [babelConfig];
} else {
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
"babel-eslint": "^5.0.0-beta3",
"babel-loader": "~6.2.0",
"babel-plugin-react-transform": "~2.0.0-beta1",
"babel-plugin-transform-decorators-legacy": "^1.3.4",
"babel-plugin-transform-runtime": "^6.3.13",
"babel-plugin-typecheck": "^3.5.1",
"babel-preset-es2015": "^6.3.13",
Expand Down
2 changes: 1 addition & 1 deletion src/client.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ if (process.env.NODE_ENV !== 'production') {
}

if (__DEVTOOLS__ && !window.devToolsExtension) {
const DevTools = require('./containers/DevTools/DevTools');
const DevTools = require('./containers/DevTools/DevTools').default;
ReactDOM.render(
<Provider store={store} key="provider">
<div>
Expand Down
2 changes: 1 addition & 1 deletion src/redux/create.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export default function createStore(customMiddleware, reducers, data) {
let finalCreateStore;
if (__DEVELOPMENT__ && __CLIENT__ && __DEVTOOLS__) {
const { persistState } = require('redux-devtools');
const DevTools = require('../containers/DevTools/DevTools');
const DevTools = require('../containers/DevTools/DevTools').default;
finalCreateStore = compose(
applyMiddleware(...middleware),
window.devToolsExtension ? window.devToolsExtension() : DevTools.instrument(),
Expand Down
8 changes: 4 additions & 4 deletions src/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,13 @@ function setupAssets(rootDir) {

function setupRenderer() {

const getRoutes = require(path.resolve(config.routes));
const reducers = require(path.resolve(config.redux.reducers));
const getRoutes = require(path.resolve(config.routes)).default;
const reducers = require(path.resolve(config.redux.reducers)).default;
const pretty = new PrettyError();

let CustomHtml;
if (config.htmlShell) {
CustomHtml = require(path.resolve(config.htmlShell));
CustomHtml = require(path.resolve(config.htmlShell)).default;
} else {
CustomHtml = Html;
}
Expand All @@ -69,7 +69,7 @@ function setupRenderer() {
// assemble custom middleware, pass req, res
const middleware = [];
if (config.redux.middleware) {
const customMiddleware = require(path.resolve(config.redux.middleware));
const customMiddleware = require(path.resolve(config.redux.middleware)).default;
each(customMiddleware, (customMiddlewareToAdd) => {
if (typeof customMiddlewareToAdd === 'function') {
middleware.push(customMiddlewareToAdd(req, res));
Expand Down

0 comments on commit 2e2901b

Please sign in to comment.