Automating SDK generation process #385
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 112e935.
…ilities-and-update-dependent-packages-for-PHP Petoss 518 find package vulnerabilities and update dependent packages for php
ci: 576 Added the slack alert code
Raghunath-S-S-J
changed the title
fooman
reviewed
Mar 12, 2025
| @@ -18,7 +18,7 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": ">=5.6", | |||
| "php": ">=8.1", | |||
There was a problem hiding this comment.
This is quite the jump and with Xero updating API responses server side that are validated against an hardcoded list client side (the last one being the identifier of the subscription plans) please consider keeping this range very wide. Or remove the hardcoded validations to avoid breaking existing installs on sites that haven't yet been able to run on later versions of php.
There was a problem hiding this comment.
I would suggest bumping to support php version 7.1 as a minimum as that will allow you to use nullable parameters which you will need to get past errors like
Deprecated: XeroAPI\XeroPHP\Models\Accounting\Item::__construct(): Implicitly marking parameter $data as nullable is deprecated, the explicit nullable type must be used instead in /var/www/vendor/xeroapi/xero-php-oauth2/lib/Models/Accounting/Item.php:254.
on php 8.4 - see
https://wiki.php.net/rfc/deprecate-implicitly-nullable-types
and
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.