Forcing different representations to use Fock and L2_norm when a component is not Gaussian #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #559 +/- ##
===========================================
+ Coverage 90.17% 90.28% +0.10%
===========================================
Files 102 102
Lines 6180 6186 +6
===========================================
+ Hits 5573 5585 +12
+ Misses 607 601 -6
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
apchytr
changed the title
ziofil
reviewed
Mar 5, 2025
ziofil
reviewed
Mar 5, 2025
mrmustard/lab_dev/samplers.py
Outdated
| @@ -169,13 +169,14 @@ def _validate_probs(self, probs: Sequence[float], atol: float) -> Sequence[float | |||
| atol: The absolute tolerance to validate with. | |||
| """ | |||
| atol = atol or settings.ATOL | |||
| probs = math.abs(probs) | |||
There was a problem hiding this comment.
is this to go from complex to float?
There was a problem hiding this comment.
It is yeah. math.real works as well. Is there a preference for which to use?
apchytr
commented
Mar 6, 2025
| @@ -122,6 +125,29 @@ def test_normalize(self, coeff): | |||
| normalized = state.normalize() | |||
| assert np.isclose(normalized.probability, 1.0) | |||
|
|
|||
| def test_normalize_poly_dim(self): | |||
| # https://github.com/XanaduAI/MrMustard/issues/481 | |||
| with settings(AUTOSHAPE_PROBABILITY=0.99999999): | |||
There was a problem hiding this comment.
@ziofil If this becomes a consistent enough issue should we just set the global AUTOSHAPE_PROBABILITY higher?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Issues like MemoryError #481 are currently present in develop. These occur when attempting to compute the L2_norm of a state with a non scalar c. The solution presented here is to force the inner product between the state and its dual to occur in Fock when the dimension of the polynomial is greater than zero. In addition to this, some issues have been raised from forcing
to_bargmannwhen two different representations meet.Description of the Change: Introduced the
_compute_L2_normhidden method. This method implements the above mentioned solution as well as provides a single source for the calculation of the L2_norm. Added #481 as a test. Representation now raises when two different ansatz are met. Circuit component now handles changing the representation and usesto_fockinsteadBenefits: normalization and purity calculation issues resolved