-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming and moving things around to match architecture #539
base: develop
Are you sure you want to change the base?
Conversation
Would love to hear people's opinion on what we should actually name things. Perhaps |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #539 +/- ##
========================================
Coverage 90.05% 90.05%
========================================
Files 102 103 +1
Lines 6222 6223 +1
========================================
+ Hits 5603 5604 +1
Misses 619 619
Continue to review full report in Codecov by Sentry.
|
Context: Offline discussion has made it apparent that certain objects within lab_dev (such as
Circuit
) should be renamed and grouped together to reflect the architectural decisions we're making. Circuits now should refer to a future 'Circuit' layer and what is currently in lab_dev is the 'Computational Graph' layer.Description of the Change: Renamed
circuits.py
tocomputational_graph.py
,circuit_components.py
tograph_component.py
. Movedgraph_component.py
,branch_and_bound.py
andcomputational_graph.py
to acomputational_graphs
folder. RenamedCircuit
toComputationalGraph
,GraphComponent
toLightGraphComponent
,CircuitComponent
toGraphComponent
. Updated docs to reflect these changes.Benefits: Makes things clearer
Possible Drawbacks: Since lab_dev has been around for so long people have most likely gotten used to terms such as
CircuitComponent
,Circuit
, etc so there will be an adjustment period.