RM-22582 Dependency tracking #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RavenNumber of Findings: 0 |
|
lgtm |
| runner_image: drydock-prod.workiva.net/workiva/smithy-runner-golang:121185 | ||
|
|
||
| script: | ||
| - glide install |
There was a problem hiding this comment.
can you add a glide.lock artifact?
|
As long as this looks like an accurate reflection of your dependencies, I am happy |
|
lgtm |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A requirement from Release Management is that dependencies are trackable. The easiest way to do this was use smithy/glide. I don't think any tests have to actually be executed in smithy, just a glide.lock generated, so I left tests in travis where non-workiva people could see them.
I also updated the go versions in travis to newer versions; as well as changed the environment variable setup to be one build with both variables instead of two builds with one environment variables each.
@stevenosborne-wf @dustinhiatt-wf
@travisreed-wf Can you verify this satisfies RM requirements?