-
Notifications
You must be signed in to change notification settings - Fork 289
Playground Documentation latest update #2175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playground Documentation latest update #2175
Conversation
e077404
to
cbabf45
Compare
@bgrgicak - Please have a look at this PR and let me know your feedback. Thanks in advance. |
|
||
You need to activate "Network access" to be able to browse for [plugins](https://w.org/plugins) and [themes](https://w.org/themes) from your WordPress instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tip is important and we should include it in the new documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
@@ -15,51 +15,96 @@ Some key features: | |||
|
|||
Via [Query Params](/developers/apis/query-api/) we can directly load in the Playground instance things such as a specific version of WordPress, a theme, a plugin or a more complex setup via blueprints (check [here](/quick-start-guide#try-a-block-a-theme-or-a-plugin) some examples). | |||
|
|||
From the Playground website there are also available some toolbars to customize your playground instance and to provide quick access to some resources and utilities. | |||
WordPress Playground is a browser-based environment that allows users to run WordPress instantly without installation. It is useful for testing, debugging, and exploring WordPress features. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this part needed? It's content is very similar to what we have on line 8 of this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @karthick-murugan for starting this documentation page update, it's been outdated for a while.
@bgrgicak - Does the php version change back to 8.1 triggered this error? Do you have some ideas regarding this error? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karthick-murugan Thank you so much for putting this together!
I am not sure how much time you'd like to invest into working on this a little further. I would suggest a slight rewrite of the documentation changes:
The Playground screen actually has four parts:
Left site, middle section and site display + Adress bar.
The other two items, you mentioned are auxiliary menus used to get out of the full screen view again.
Left Navigation
The left site lets you control the overall playground browser instance.
The notes are missing
-
mentioning that you can save more than once site in this instance.
-
The four resources links on the bottom
-- Preview WordPress PR
-- More demos
-- Documentation
-- GitHub -
and the three dot menu with the additional features.
-- Preview WordPress PR
-- Preview Gutenberg PR
-- Import from GitHub
-- Import from Zip
The mention of the submenus can certainly be left for a future PR.
Middle Section
The middle section the current site, if you only have one site, it's the default site called Temporary Playground. If you have more than one site saved, it changes according to the sites, selected from the left site.
The right page, displays the current site and automatically goes full screen when selected.
I would use the current Playground Settings explanation and move them to the middle section. They are also not the overall playground settings, but the settings for the active site selected.
There is more explanation necessary to put "Temporary Playground" into context. It is the first site, or default site. It's not a UI name as that changes with there are more than one site stored in the playground.
Site View
Full screen display of the site
Use either the left or the right icon to get back to the other sections of the playground instance.
3960331
to
c116e74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karthick-murugan Thanks for all the changes to make it more comprehensive. That's awesome!
On line 10 the file reads "Some key features:"
I would think that Key Features is already a selective term and doesn't the "some" quantifier. If you want to add a qualifier, it could be "Main key features", though
(I tried to comment inline, but there wasn't a way to add a comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bph I thought to add individual screenshots of each section and that why added it. I will remove it now and update it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
Also, I am unsure if it's possible to headline the three panes better, instead of calling them "Left Navigation" or "Middle section" :-) @karthick-murugan @brandonpayton @bgrgicak What do you think? Any better ideas? |
Hmm, I am sorry, I am not familiar with the CI checks. That's more a @bgrgicak or @adamziel question. |
My suggestion. |
Excellent Suggestions @karthick-murugan 🎉 👏 |
@bph All changes are updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel some of the image take an awful big amount of space, with little value, especially the Site-Explorer. I tried to figure out how to control the image sizes in Docusaurus, unsuccessfully. But other image would also be better with smaller sizes...
For now, all I can think of is to resize the images offline and upload the smaller sizes.
@karthick-murugan @bgrgicak What do you think?
With the help of @juanmaguitar I figured it out: If you are up for it, @karthick-murugan, you can use a different way to control the size of the image, so they don't take so much space. An example code looks like this:
This snippet from here
What do you think? Would you be up for it? |
@bph - I have updated the screenshot sizes. Please check if it will work for us. |
@bph Updated the screenshots. Please have a look. |
@bgrgicak I'll take a look again, tomorrow. Please see if the failing test |
Thank you @bph. I think CI Pipeline error can be ignored since the PHP files are to be relocated anyway as per @adamziel mentioned here #2179 (comment) |
Until we fix the tests we can run I ran |
The PHP linting failure can be safely ignored. I just removed that check entirely in trunk. We should remove the entire PHP module from this repo – it won't be developed here as the entire setup is quite cumbersome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So much better now. Thank you, @karthick-murugan - It's now in a stage that could be merged
Thank you @bph |
Fixes the playground documentation outdated content mentioned in this issue #2168
Pull Request Summary
This PR updates the WordPress Playground Web Instance documentation to reflect the latest UI changes and features. The previous documentation contained outdated screenshots and descriptions, which have been updated with the most recent UI elements, including the relocation of Playground options to the Playground Manager.