Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizer: Add tooltips to responsive preview icons for improved usability #8593

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

himanshupathak95
Copy link

@himanshupathak95 himanshupathak95 commented Mar 26, 2025

Trac ticket: https://core.trac.wordpress.org/ticket/36447

This PR adds tooltip functionality to the responsive preview icons in the WordPress Customizer. By displaying tooltips on hover, users can now clearly identify the purpose of each device preview button before clicking them, enhancing usability and accessibility.

The implementation:

  • Uses aria-label attributes for tooltip content, which maintains accessibility
  • Follows UI patterns similar to tooltip implementations elsewhere in the admin

Before

Screen.Recording.2025-03-26.at.12.58.19.mov

After

Screen.Recording.2025-03-26.at.12.57.26.mov

@himanshupathak95 himanshupathak95 marked this pull request as ready for review March 26, 2025 07:30
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props abcd95.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@himanshupathak95
Copy link
Author

The failing tests seem unrelated to the changes made in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant