-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Improve wp_unique_id_from_values()
unit tests
#8590
Fix: Improve wp_unique_id_from_values()
unit tests
#8590
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks @Debarghya-Banerjee!
This looks pretty close to what I had in mind. A couple quick observations:
- Given that all dataProvider responses return the same
$prefix
value, we can probably eliminate that and only return the data for each set. - Rather than
$output1
,$output2
, etc. Can the variable names be more descriptive? $unique_id_1, $unique_id_prefixed_1, etc.?
Hi @joemcgill, I have pushed the updates, can you please have a look into it once. Thanks. |
Trac Ticket: Core-63175
Problem Statement
The original unit tests for the
wp_unique_id_from_values()
function relied on specific hash outputs, which caused test failures in certain hosting environments due to differences in how data is serialized and hashed. These tests assumed consistent hash values across all environments for the same input, which was not guaranteed. Additionally, the tests did not properly validate the handling of the prefix parameter.Solution
Ensured Consistent Output:
Verified Uniqueness: