Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement altering column with SET DEFAULT and DROP DEFAULT #152

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Implement altering column with SET DEFAULT and DROP DEFAULT #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5cd057d
Update CHANGE COLUMN logic to execute a callback for each column
JanJakes Aug 15, 2024
86ba0e5
Extract CHANGE COLUMN logic to a private method
JanJakes Aug 15, 2024
d0c4b6d
Implement altering column with SET DEFAULT and DROP DEFAULT
JanJakes Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 88 additions & 0 deletions tests/WP_SQLite_Translator_Tests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3056,6 +3056,94 @@ public function testSelectVariable( $variable_name ) {
$this->assertQuery( "SELECT $variable_name;" );
}

public function testAlterColumnSetAndDropDefault() {
$this->assertQuery(
'CREATE TABLE _tmp_table (
name varchar(20) NOT NULL
);'
);
$result = $this->assertQuery( 'DESCRIBE _tmp_table' );
$this->assertEquals(
array(
(object) array(
'Field' => 'name',
'Type' => 'varchar(20)',
'Null' => 'NO',
'Key' => '',
'Default' => '',
'Extra' => '',
),
),
$result
);

// SET DEFAULT
$this->assertQuery( "ALTER TABLE _tmp_table ALTER COLUMN name SET DEFAULT 'abc'" );
$result = $this->assertQuery( 'DESCRIBE _tmp_table' );
$this->assertEquals(
array(
(object) array(
'Field' => 'name',
'Type' => 'varchar(20)',
'Null' => 'NO',
'Key' => '',
'Default' => 'abc',
'Extra' => '',
),
),
$result
);

// DROP DEFAULT
$this->assertQuery( 'ALTER TABLE _tmp_table ALTER COLUMN name DROP DEFAULT' );
$result = $this->assertQuery( 'DESCRIBE _tmp_table' );
$this->assertEquals(
array(
(object) array(
'Field' => 'name',
'Type' => 'varchar(20)',
'Null' => 'NO',
'Key' => '',
'Default' => '',
'Extra' => '',
),
),
$result
);

// multiple ALTER statements, with and without the COLUMN keyword
$this->assertQuery( "ALTER TABLE _tmp_table ADD COLUMN value varchar(255) DEFAULT 'aaa'" );
$this->assertQuery(
"ALTER TABLE _tmp_table
ALTER name SET DEFAULT 'bbb',
ALTER COLUMN name DROP DEFAULT,
ALTER value DROP DEFAULT,
ALTER COLUMN name SET DEFAULT 'ccc'"
);
$result = $this->assertQuery( 'DESCRIBE _tmp_table' );
$this->assertEquals(
array(
(object) array(
'Field' => 'name',
'Type' => 'varchar(20)',
'Null' => 'NO',
'Key' => '',
'Default' => '',
'Extra' => '',
),
(object) array(
'Field' => 'value',
'Type' => 'varchar(255)',
'Null' => 'YES',
'Key' => '',
'Default' => 'aaa',
'Extra' => '',
),
),
$result
);
}

public static function mysqlVariablesToTest() {
return array(
// NOTE: This list was derived from the variables used by the UpdraftPlus plugin.
Expand Down
Loading
Loading