Refactor: Prevent some undefined array key warnings.

[cbravobernal]

What

While working on SCF. I have been receiving several warnings that made field creation difficult. Something like this:

Test

• Check that you have similar warnings than the ones shown in the screenshot when you try to create custom fields.
• Check that with the PR they are gone.

[pkevan]

was this intentionally changed to a strict comparison?

[cbravobernal]

Yep, otherwise phpcs was complaining about it. It should not be risky. As both values come from esc_attrfunctions, which should return a string.

[pkevan]

I wonder if it might be best to have a helper function for all these isset checks, as it makes the code harder to read as a result?

[cbravobernal]

I wonder if it might be best to have a helper function for all these isset checks, as it makes the code harder to read as a result?

I found indeed an acf_maybe_get function.