Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue/144 – Skip unnecesary sleep() calls in several places during parsing. #200

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

issue/144 – Skip unnecesary sleep() calls in several places during parsing. #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5558e9
Update composer.lock.
DrewAPicture Jun 7, 2018
2499459
Default any $skip_sleep parameters to true.
DrewAPicture Jun 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 62 additions & 28 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/class-command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ protected function _get_phpdoc_data( $path, $format = 'json' ) {
* @param bool $skip_sleep If true, the sleep() calls are skipped.
* @param bool $import_ignored If true, functions marked `@ignore` will be imported.
*/
protected function _do_import( array $data, $skip_sleep = false, $import_ignored = false ) {
protected function _do_import( array $data, $skip_sleep = true, $import_ignored = false ) {

if ( ! wp_get_current_user()->exists() ) {
WP_CLI::error( 'Please specify a valid user: --user=<id|login>' );
Expand Down
11 changes: 6 additions & 5 deletions lib/class-importer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,10 @@ public function __construct( array $args = array() ) {
* Import the PHPDoc $data into WordPress posts and taxonomies
*
* @param array $data
* @param bool $skip_sleep Optional; defaults to false. If true, the sleep() calls are skipped.
* @param bool $skip_sleep Optional. Whether to skip the sleep() calls. Default true.
* @param bool $import_ignored_functions Optional; defaults to false. If true, functions marked `@ignore` will be imported.
*/
public function import( array $data, $skip_sleep = false, $import_ignored_functions = false ) {
public function import( array $data, $skip_sleep = true, $import_ignored_functions = false ) {
global $wpdb;

$time_start = microtime(true);
Expand Down Expand Up @@ -253,10 +253,10 @@ protected function insert_term( $term, $taxonomy, $args = array() ) {
* For a specific file, go through and import the file, functions, and classes.
*
* @param array $file
* @param bool $skip_sleep Optional; defaults to false. If true, the sleep() calls are skipped.
* @param bool $skip_sleep Optional. Whether to skip the sleep() calls. Default true.
* @param bool $import_ignored Optional; defaults to false. If true, functions and classes marked `@ignore` will be imported.
*/
public function import_file( array $file, $skip_sleep = false, $import_ignored = false ) {
public function import_file( array $file, $skip_sleep = true, $import_ignored = false ) {

/**
* Filter whether to proceed with importing a prospective file.
Expand All @@ -266,8 +266,9 @@ public function import_file( array $file, $skip_sleep = false, $import_ignored =
* @param bool $display Whether to proceed with importing the file. Default true.
* @param array $file File data
*/
if ( ! apply_filters( 'wp_parser_pre_import_file', true, $file ) )
if ( ! apply_filters( 'wp_parser_pre_import_file', true, $file ) ) {
return;
}

// Maybe add this file to the file taxonomy
$slug = sanitize_title( str_replace( '/', '_', $file['path'] ) );
Expand Down