Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rephrase closing window message #2672

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kkarbowiak
Copy link
Contributor

I think the new version better conveys the fact that the comparison itself took a long time and the window holds its result.

@sdottaka
Copy link
Member

Thank you for the PR. I'm not confident with my English skills, but the original sentence doesn't seem bad to me. I'd like to hear others' opinions on this.

@kkarbowiak
Copy link
Contributor Author

Thank you for the PR. I'm not confident with my English skills, but the original sentence doesn't seem bad to me. I'd like to hear others' opinions on this.

The original sentence is not bad and maybe I am nitpicking. Let's see what others think.

@YevgenBorodkin
Copy link

I am not native, but the new version looks good to me.
On the same note, did you see the message above?
"You are about to close the window that is comparing folders. Are you sure you want to close the window?"
Following the same logic, "windows" should not compare folders

@dcog989
Copy link
Contributor

dcog989 commented Mar 20, 2025

Native English here - the change is not good. It doesn't add any clarity, and is 'awkward' phrasing.

However, there is room for improvement via brevity:

"You are about to close the folder comparison window that took a significant amount of time. Are you sure you want to close the window?"

should be:

"You are about to close the folder comparison window, which took a long time. Are you sure?"

There are many instances of overly verbose messages. @sdottaka - would you be interested in a pull request that reworks the English file for brevity / clarity?

@sdottaka
Copy link
Member

Thank you for your comments.
I agree with @dcog989's suggestion:
"You are about to close the folder comparison window, which took a long time. Are you sure?"
A PR would be welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants