Migrate from Node Sass to Sass for our asset building. #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves us away from the now deprecated Node Sass, to just Sass. It also updates our
npm runcommands to produce resulting css files to match what we're expecting.On top of that I made use of a migrator package to convert how we reverence colors, mixins, and similar for easier conversion.
Output in the generated CSS files look overall fine with biggest changes being line breaks, less tabbed nesting, and some color reference changes from hex to rgb, among other minor details.
Resources on changes:
https://sass-lang.com/documentation/cli/dart-sass/
https://sass-lang.com/documentation/cli/migrator/
https://sass-lang.com/blog/import-is-deprecated/
https://sass-lang.com/documentation/breaking-changes/mixed-decls/